Removed Output::Print()#1570
Merged
chakrabot merged 1 commit intochakra-core:release/1.3from Sep 13, 2016
Merged
Conversation
The trace is only printed if host has `idleGC` implemented, so haven't noticed so far in `ch.exe`. This is to address nodejs/node-chakracore#115
Contributor
Author
|
@digitalinfinity, can you take a look? |
Contributor
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Sep 13, 2016
Merge pull request #1570 from kunalspathak:removedtraces The trace is only printed if host has `idleGC` implemented, so haven't noticed so far in `ch.exe` but was showing up in node+chakracore after my idleGC changes. This will fix nodejs/node-chakracore#115
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Sep 13, 2016
This brings down change chakra-core/ChakraCore#1570 from chakracore to delete debugging traces. Fixes: nodejs#115
2 tasks
chakrabot
pushed a commit
that referenced
this pull request
Sep 13, 2016
Merge pull request #1570 from kunalspathak:removedtraces The trace is only printed if host has `idleGC` implemented, so haven't noticed so far in `ch.exe` but was showing up in node+chakracore after my idleGC changes. This will fix nodejs/node-chakracore#115
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Sep 15, 2016
This brings down change chakra-core/ChakraCore#1570 from chakracore to delete debugging traces. Fixes: nodejs#115 PR-URL: nodejs#116 Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trace is only printed if host has
idleGCimplemented, so haven't noticed so far inch.exebut was showing up in node+chakracore after my idleGC changes.This will fix nodejs/node-chakracore#115